[CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.21.0
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Ruben Q L
• Created: 30/Aug/19 07:12
• Updated: 10/Sep/19 21:36
• Resolved: 01/Sep/19 08:26

Description

The method EnumerableNestedLoopJoin#predicate (that generates a Predicate Expression based on a RexNode condition) has been copied pasted as EnumerableBatchNestedLoopJoin#generatePredicate due to CALCITE-2979, and EnumerableHashJoin#generatePredicate due to CALCITE-2973.
The goal of this ticket is to refactor that method into a single location (e.g. EnumUtils) where it can be accessible by all 3 Enumerable Joins.

Issue Links

• links to: GitHub Pull Request #1424