Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3309

Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.21.0
    • Component/s: None

      Description

      The method EnumerableNestedLoopJoin#predicate (that generates a Predicate Expression based on a RexNode condition) has been copied pasted as EnumerableBatchNestedLoopJoin#generatePredicate due to CALCITE-2979, and EnumerableHashJoin#generatePredicate due to CALCITE-2973.
      The goal of this ticket is to refactor that method into a single location (e.g. EnumUtils) where it can be accessible by all 3 Enumerable Joins.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rubenql Ruben Q L
                Reporter:
                rubenql Ruben Q L
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m