[CALCITE-3309] Refactor generatePredicate method from EnumerableNestedLoopJoin/EnumerableHashJoin/EnumerableBatchNestedLoopJoin into a single location - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Trivial
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.21.0
Component/s: None
Labels:
- pull-request-available

Description

The method EnumerableNestedLoopJoin#predicate (that generates a Predicate Expression based on a RexNode condition) has been copied pasted as EnumerableBatchNestedLoopJoin#generatePredicate due to ~~CALCITE-2979~~, and EnumerableHashJoin#generatePredicate due to ~~CALCITE-2973~~.
The goal of this ticket is to refactor that method into a single location (e.g. EnumUtils) where it can be accessible by all 3 Enumerable Joins.