[CALCITE-3296] Decorrelator gives empty result after decorrelating sort rel with null offset and fetch

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.21.0
• Labels: pull-request-available
• Assignee: Juhwan Kim
• Reporter: Juhwan Kim
• Created: 26/Aug/19 18:39
• Updated: 10/Sep/19 21:37
• Resolved: 27/Aug/19 20:51

Description

It seems like I introduced a bug with the recent decorrelator patch. Sort rel with null offset and fetch would end up becoming an empty value since decorrelator would call sortLimit builder with 0 limit and 0 offset. It should pass negative values to builder when values are null.

https://github.com/apache/calcite/blob/e863294ccfbed9dd520c999f75ed0bbe03f9fb1d/core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java#L423

Issue Links

• links to: GitHub Pull Request #1416