[CALCITE-3247] In JDBC adapter, when generating SQL for Hive, transform SUBSTRING function to correct format

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.22.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Danny Chen
• Reporter: Jacky Woo
• Created: 13/Aug/19 07:13
• Updated: 06/Mar/20 04:36
• Resolved: 23/Sep/19 08:56

Description

Let's assume sql = SELECT SUBSTRING('ABC', 2)

When we use HiveSqlDialect and transform "sql", we expect SUBSTRING(' abc', 2)，but get SUBSTRING(' abc' FROM 2) which is incorrect  sql format in hive.

So maybe HiveSqlDialect behavior should be changed when transform function SUBSTRING:

1. SELECT SUBSTRING('ABC', 2)  =>  SELECT SUBSTRING('ABC', 2)
2. SELECT SUBSTRING('ABC', 2, 3)  =>  SELECT SUBSTRING('ABC', 2, 3) 
3. SELECT SUBSTRING('ABC' FROM 2) => SELECT SUBSTRING('ABC', 2) 
4. SELECT SUBSTRING('ABC' FROM 2 FOR 3) => SELECT SUBSTRING('ABC', 2, 3) 

 

Issue Links

• links to: Github PR
• links to: GitHub Pull Request #1373