[CALCITE-3243] Incomplete validation of operands in JSON functions

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.20.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Matt Wang
• Reporter: Stamatis Zampetakis
• Created: 12/Aug/19 14:41
• Updated: 10/Dec/19 15:32

Description

The operands of various JSON functions are not validated correctly. 

Consider for instance the JSON_VALUE function and the following calls:

json_value('{\"foo\":100}', 'strict $.foo')"
json_value(1, 'strict $.foo')"
json_value(TRUE, 'strict $.foo')"

The first call is legal but the next are not; if I am not wrong the operands should be always CHAR or VARCHAR literals which is not the case above.

Queries involving such calls fail at runtime when compiling generated code. I guess that such kind of problems should be captured by the validator and we should not even arrive at the code generation step.

The problems can be easily reproduced by adding such calls in the SqlOperatorBaseTest.

The problem does not only affect JSON_VALUE but other JSON functions (such as JSON_QUERY etc.) as well.

Issue Links

• is related to: CALCITE-2869 JSON data type support
• links to: GitHub Pull Request #1406