[CALCITE-3215] Simplification may have not fully simplified IS NOT NULL expressions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.21.0
• Labels: pull-request-available
• Assignee: Zoltan Haindrich
• Reporter: Zoltan Haindrich
• Created: 26/Jul/19 09:07
• Updated: 10/Sep/19 21:37
• Resolved: 02/Aug/19 15:10

Description

CALCITE-2929 have added a safety check to avoid simplifying problematic cases.

The safety check apparently misses some kinds, for example: UNARY_PLUS

  @Test public void testIsNullSimplificationWithUnaryPlus() {
    RexNode expr =
        isNotNull(coalesce(unaryPlus(vInt(1)), vIntNotNull(0)));
    RexNode s = simplify.simplifyUnknownAs(expr, RexUnknownAs.UNKNOWN);

    assertThat(expr.isAlwaysTrue(), is(true));
    assertThat(s, is(trueLiteral));
  }

Issue Links

• links to: GitHub Pull Request #1339