[CALCITE-3211] List of MutableRel may fail to be identified by SubstitutionVisitor during matching - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.21.0
Component/s: None
Labels:
- pull-request-available

Description

Current implementation of MutableRels::toMutables is as below:

  private static List<MutableRel> toMutables(List<RelNode> nodes) {
    return Lists.transform(nodes, MutableRels::toMutable);
  }

Thus every time we get from the result list, a new MutableRel will be created:

  private static class TransformingRandomAccessList<F, T> extends AbstractList<T>
      implements RandomAccess, Serializable {
    final List<F> fromList;
    final Function<? super F, ? extends T> function;

    TransformingRandomAccessList(List<F> fromList, Function<? super F, ? extends T> function) {
      this.fromList = checkNotNull(fromList);
      this.function = checkNotNull(function);
    }

    @Override
    public T get(int index) {
      return function.apply(fromList.get(index));
    }
......