Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3207

Fail to convert Join RelNode with like condition to sql statement

    XMLWordPrintableJSON

    Details

      Description

      Hi all
      I have a problem when using calcite, which is 'relnode convert sql statement

      example:

       

      I create a test like below

      // RelToSqlConverterTest.java
      @Test public void testLeftJoinRel2Sql() {
        final RelBuilder builder = relBuilder();
        final RelNode rel = builder
            .scan("EMP")
            .scan("DEPT")
            .join(JoinRelType.LEFT, builder.and(
                    builder.call(SqlStdOperatorTable.EQUALS,
                        builder.field(2, 0, "DEPTNO"),
                        builder.field(2, 1, "DEPTNO")
                    ), builder.call(SqlStdOperatorTable.LIKE,
                        builder.field(2, 1, "DNAME"),
                        builder.literal("ACCOUNTING"))))
            .build();
        final String sql = toSql(rel);
        final String expectedSql = "SELECT *\n" +
            "FROM \"scott\".\"EMP\"\n" +
            "LEFT JOIN \"scott\".\"DEPT\" ON \"EMP\".\"DEPTNO\" = \"DEPT\".\"DEPTNO\"\n" +
            "AND \"DEPT\".\"DNAME\" LIKE 'ACCOUNTING'";
        assertThat(sql, isLinux(expectedSql));
      }

       

      this relNode cannot convert sql statement.

      I try to debug it, `org.apache.calcite.rel.rel2sql.SqlImplementor#convertConditionToSqlNode` may forgot to handle this case, which sqlKind is SqlKind.LIKE.

      If it is a bug, I am willing to fix it.

      Thanks.

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                danny0405 Danny Chen
                Reporter:
                wojustme Xurenhe
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 20m
                  2h 20m