[CALCITE-3206] Better error message when param type incompatibility

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Jin Xing
• Created: 22/Jul/19 12:50
• Updated: 23/Jul/19 05:29
• Resolved: 23/Jul/19 05:29

Description

In current code, when we query like below

  @Test public void test() {
    CalciteAssert.model(HR_FKUK_MODEL)
      .query("select * from \"events\" where \"eventid\"='123'")
      .returns(CalciteAssert.outputResult());
  }

Where eventid is of INTEGER type, Calcite will throw exception as below

Caused by: org.codehaus.commons.compiler.CompileException: Line 13, Column 100: Cannot compare types "int" and "java.lang.String"
	at org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:12211)
	at org.codehaus.janino.UnitCompiler.compileBoolean2(UnitCompiler.java:4239)
	at org.codehaus.janino.UnitCompiler.access$6600(UnitCompiler.java:215)
	at org.codehaus.janino.UnitCompiler$14.visitBinaryOperation(UnitCompiler.java:3957)
	at org.codehaus.janino.UnitCompiler$14.visitBinaryOperation(UnitCompiler.java:3935)
	at org.codehaus.janino.Java$BinaryOperation.accept(Java.java:4864)
	at org.codehaus.janino.UnitCompiler.compileBoolean(UnitCompiler.java:3935)
	at org.codehaus.janino.UnitCompiler.compile2(UnitCompiler.java:2475)

It's kind of hard to understand for user to refine the sql

Issue Links

• is related to: CALCITE-2302 Implicit type cast support
• links to: GitHub Pull Request #1327