Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3146

Support the detection of nested aggregations for JdbcAggregate in SqlImplementor.

Rank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.19.0
    • 1.21.0
    • core

    Description

      The detection of nested aggregations in SqlImplementor.java is only for 

      LogicalAggregate:

       

      if (rel instanceof LogicalAggregate
          && !dialect.supportsNestedAggregations()
          && hasNestedAggregations((LogicalAggregate) rel)) {
        needNew = true;
      }
      

      It should also support other sub-class of Aggregate such as JdbcAggregate .

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            winipanda TANG Wen-hui
            winipanda TANG Wen-hui
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                Slack

                  Issue deployment