[CALCITE-3124] Infinite rule matching when AggregateRemoveRule is enabled for SUM0

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Forward Xu
• Reporter: Haisheng Yuan
• Created: 11/Jun/19 23:57
• Updated: 04/Dec/19 11:44

Description

Make the following changes (uncomment return clause) to AggregateRemoveRule, the test case JdbcTest.testHavingNot2 won't complete due to infinite rule matching.

--- a/core/src/main/java/org/apache/calcite/rel/rules/AggregateRemoveRule.java
+++ b/core/src/main/java/org/apache/calcite/rel/rules/AggregateRemoveRule.java
@@ -102,7 +102,7 @@ public void onMatch(RelOptRuleCall call) {
         if (aggregation.getKind() == SqlKind.SUM0) {
         // Bail out for SUM0 to avoid potential infinite rule matching,
         // because it may be generated by transforming SUM aggregate
         // function to SUM0 and COUNT.
-        return;
+//        return;
       }
       final SqlSplittableAggFunction splitter =
           Objects.requireNonNull(

Issue Links

• is related to: CALCITE-3505 Infinite matching of FilterProjectTransposeRule causes stackoverflow