Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-3093

Remove JDBC connection calls from PlannerImpl

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.20.0
    • core

    Description

      Currently the class PlannerImpl creates JDBC connections[1] internally to instantiate RelOptPlanner. For improving the design I suggest to reverse the call chain, for example, we can make JDBC API call PlannerImpl to create RelOptPlanner, SqlValidator, SqlToRelConverter instances, etc.

      This JIRA topic is the first step of the improvement - we should decouple the use of JDBC API from PlannerImpl. Planner API is designed to be a reusable toolkit and we should make it work individually without the help of JDBC API.

      [1] https://github.com/apache/calcite/blob/4e1b68e3c0b2a90832cc790c6166cebb14ae2970/core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java#L143-L151

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            zhztheplayer Hongze Zhang
            zhztheplayer Hongze Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 0.5h
                0.5h

                Slack

                  Issue deployment