[CALCITE-3093] Remove JDBC connection calls from PlannerImpl

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.20.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Hongze Zhang
• Reporter: Hongze Zhang
• Created: 27/May/19 09:29
• Updated: 24/Jun/19 15:02
• Resolved: 30/May/19 08:35

Description

Currently the class PlannerImpl creates JDBC connections[1] internally to instantiate RelOptPlanner. For improving the design I suggest to reverse the call chain, for example, we can make JDBC API call PlannerImpl to create RelOptPlanner, SqlValidator, SqlToRelConverter instances, etc.

This JIRA topic is the first step of the improvement - we should decouple the use of JDBC API from PlannerImpl. Planner API is designed to be a reusable toolkit and we should make it work individually without the help of JDBC API.

[1] https://github.com/apache/calcite/blob/4e1b68e3c0b2a90832cc790c6166cebb14ae2970/core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java#L143-L151

Issue Links

• links to: GitHub Pull Request #1241