Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.9.0
    • Component/s: None

      Description

      would be good to have the ability to push a cancel() call down to the underlying framework.

      this would allow for a Cascading Flow to be stopped mid-flight.

      ---------------- Imported from GitHub ----------------
      Url: https://github.com/julianhyde/optiq/issues/30
      Created by: cwensel
      Labels:
      Created at: Sun Mar 17 03:06:57 CET 2013
      State: open

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Relates to CALCITE-612, but the fix to that issue is inadequate: it only checks for CLOSED queries and therefore does not find queries that have merely been canceled.

          Show
          julianhyde Julian Hyde added a comment - Relates to CALCITE-612 , but the fix to that issue is inadequate: it only checks for CLOSED queries and therefore does not find queries that have merely been canceled.
          Hide
          julianhyde Julian Hyde added a comment -

          Canceling a long-running planning process is part of implementing cancel. We need to use the same type of flag (or the same flag) for canceling the planner as for canceling the query.

          Show
          julianhyde Julian Hyde added a comment - Canceling a long-running planning process is part of implementing cancel. We need to use the same type of flag (or the same flag) for canceling the planner as for canceling the query.
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/d9eb4383 .
          Hide
          vladimirsitnikov Vladimir Sitnikov added a comment -

          While the change itself looks good, it looks like cancel flag is not pushed to the "underlying framework" as per ticket description, so I'm not that inclined to mark this one as "resolved"

          Show
          vladimirsitnikov Vladimir Sitnikov added a comment - While the change itself looks good, it looks like cancel flag is not pushed to the "underlying framework" as per ticket description, so I'm not that inclined to mark this one as "resolved"
          Hide
          julianhyde Julian Hyde added a comment -

          While the fix doesn't go as far as the description, it still does a lot. If the framework is running in the same JVM it can poll the cancel flag. If a particular framework uses distributed/remote execution it can (in principle - I haven't tried it) generate code so that the cancel is propagated to the remote node(s). I think it's correct to mark this case complete and move on; feel free to log a follow-on case for any remaining work.

          Show
          julianhyde Julian Hyde added a comment - While the fix doesn't go as far as the description, it still does a lot. If the framework is running in the same JVM it can poll the cancel flag. If a particular framework uses distributed/remote execution it can (in principle - I haven't tried it) generate code so that the cancel is propagated to the remote node(s). I think it's correct to mark this case complete and move on; feel free to log a follow-on case for any remaining work.
          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Resolved in release 1.9.0 (2016-09-22)

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.9.0 (2016-09-22)

            People

            • Assignee:
              Unassigned
              Reporter:
              github-import GitHub Import
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development