Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-30

Implement Statement.cancel method

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.9.0
        • Component/s: None

          Description

          would be good to have the ability to push a cancel() call down to the underlying framework.

          this would allow for a Cascading Flow to be stopped mid-flight.

          ---------------- Imported from GitHub ----------------
          Url: https://github.com/julianhyde/optiq/issues/30
          Created by: cwensel
          Labels:
          Created at: Sun Mar 17 03:06:57 CET 2013
          State: open

            Issue Links

            depends upon

            Improvement - An improvement or enhancement to an existing feature or task. CALCITE-872 Add support for aborting the query optimization process

            • Major - Major loss of function.
            • Open
            is related to

            Bug - A problem which impairs or prevents the functions of the product. CALCITE-942 AvaticaConnection should fail-fast when it has been closed

            • Major - Major loss of function.
            • Open

            Bug - A problem which impairs or prevents the functions of the product. CALCITE-612 Update AvaticaStatement to handle cancelled queries

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. CALCITE-1227 Add streaming CSV table

            • Major - Major loss of function.
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. CALCITE-1301 Add cancel flag to AvaticaResultSet

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Relates to CALCITE-612, but the fix to that issue is inadequate: it only checks for CLOSED queries and therefore does not find queries that have merely been canceled.

              Show
              julianhyde Julian Hyde added a comment - Relates to CALCITE-612 , but the fix to that issue is inadequate: it only checks for CLOSED queries and therefore does not find queries that have merely been canceled.
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Canceling a long-running planning process is part of implementing cancel. We need to use the same type of flag (or the same flag) for canceling the planner as for canceling the query.

              Show
              julianhyde Julian Hyde added a comment - Canceling a long-running planning process is part of implementing cancel. We need to use the same type of flag (or the same flag) for canceling the planner as for canceling the query.
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/d9eb4383.

              Show
              julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/d9eb4383 .
              Hide
              Permalink
              vladimirsitnikov Vladimir Sitnikov added a comment -

              While the change itself looks good, it looks like cancel flag is not pushed to the "underlying framework" as per ticket description, so I'm not that inclined to mark this one as "resolved"

              Show
              vladimirsitnikov Vladimir Sitnikov added a comment - While the change itself looks good, it looks like cancel flag is not pushed to the "underlying framework" as per ticket description, so I'm not that inclined to mark this one as "resolved"
              Hide
              Permalink
              julianhyde Julian Hyde added a comment -

              While the fix doesn't go as far as the description, it still does a lot. If the framework is running in the same JVM it can poll the cancel flag. If a particular framework uses distributed/remote execution it can (in principle - I haven't tried it) generate code so that the cancel is propagated to the remote node(s). I think it's correct to mark this case complete and move on; feel free to log a follow-on case for any remaining work.

              Show
              julianhyde Julian Hyde added a comment - While the fix doesn't go as far as the description, it still does a lot. If the framework is running in the same JVM it can poll the cancel flag. If a particular framework uses distributed/remote execution it can (in principle - I haven't tried it) generate code so that the cancel is propagated to the remote node(s). I think it's correct to mark this case complete and move on; feel free to log a follow-on case for any remaining work.
              Hide
              Permalink
              jcamachorodriguez Jesus Camacho Rodriguez added a comment -

              Resolved in release 1.9.0 (2016-09-22)

              Show
              jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.9.0 (2016-09-22)

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  github-import GitHub Import
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development