[CALCITE-2954] SubQueryJoinRemoveRule and SubQueryProjectRemoveRule passing on empty set instead of set of correlation id

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.20.0
• Component/s: core
• Labels: pull-request-available sub-query
• Assignee: Vineet Garg
• Reporter: Vineet Garg
• Created: 26/Mar/19 01:22
• Updated: 24/Jun/19 15:02
• Resolved: 05/Apr/19 04:51

Description

Call to apply takes set of CorrelationId but both SubQueryJoinRemoveRule and SubQueryProjectRemoveRule are passing empty set for whatever reason.

I believe the correct thing to do here is to pass on the actual set of CorrelationId like SubQueryFilterRemoveRule

Ref:

final RexNode target = apply(e, ImmutableSet.of(),
    logic, builder, 2, fieldCount);

Issue Links

• Dependent: DRILL-7050 RexNode convert exception in subquery
• links to: GitHub Pull Request #1135