[CALCITE-2898] RelOptUtil#splitJoinCondition must consider RexFieldAccess referencing RexInputRef

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Bug
• Affects Version/s: 1.18.0
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Ruben Q L
• Created: 06/Mar/19 13:46
• Updated: 10/May/19 17:45
• Resolved: 16/Apr/19 07:36

Description

RelOptUtil#splitJoinCondition "Splits out the equi-join components of a join condition, and returns what's left (remaining join filters that are not equijoins)". This works fine in case of RexInputRef operands in the condition (e.g. $0 = $1), but if any of the operands is a RexFieldAccess referencing a RexInputRef (e.g. $0 = $1.id), then the condition will NOT be detected as an equi-join and will be returned as if it were a non-equijoin.
This can lead to undesired consequences, e.g JoinInfo#of would return a NonEquiJoinInfo object instead of an EquiJoinInfo object, which can generate problems if, for example, we are creating a SemiJoin (which requires an EquiJoinInfo object)

Issue Links

• is related to: CALCITE-2973 Allow theta joins that have equi conditions to be executed using a hash join algorithm
• links to: GitHub Pull Request #1091