[CALCITE-2895] Some arguments are undocumented in constructor of LogicalAggregate

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.19.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Chunwei Lei
• Reporter: Chunwei Lei
• Created: 06/Mar/19 09:23
• Updated: 21/Mar/19 05:26
• Resolved: 08/Mar/19 02:39

Description

There are some undocumented arguments in constructor of LogicalAggregate, including traitSet and indicator.

  /**
   * Creates a LogicalAggregate.
   *
   * <p>Use {@link #create} unless you know what you're doing.
   *
   * @param cluster  Cluster that this relational expression belongs to
   * @param child    input relational expression
   * @param groupSet Bit set of grouping fields
   * @param groupSets Grouping sets, or null to use just {@code groupSet}
   * @param aggCalls Array of aggregates to compute, not null
   */
  public LogicalAggregate(
      RelOptCluster cluster,
      RelTraitSet traitSet,
      RelNode child,
      boolean indicator,
      ImmutableBitSet groupSet,
      List<ImmutableBitSet> groupSets,
      List<AggregateCall> aggCalls) {
    super(cluster, traitSet, child, indicator, groupSet, groupSets, aggCalls);
  }

Issue Links

• links to: GitHub Pull Request #1088