[CALCITE-2854] Codegen compile error when implementing unary minus function with data type BigDecimal

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.18.0
• Fix Version/s: 1.25.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Lai Zhou
• Created: 18/Feb/19 09:33
• Updated: 22/Aug/20 18:48
• Resolved: 27/Jul/20 05:14

Description

case:

  @Test public void test() throws Exception {
    final String cr = "create table t (a DECIMAL)";
    final String se = "select -a as aa from t";
    Connection c = connect();
    Statement s = c.createStatement();
    s.execute(cr);
    s.executeQuery(se);
  }

error msg: 

Caused by: org.codehaus.commons.compiler.CompileException: Line 21, Column 71: Object of type "java.math.BigDecimal" cannot be converted to a numeric type

public Object current() {
final java.math.BigDecimal current = inputEnumerator.current() == null ? (java.math.BigDecimal) null : org.apache.calcite.runtime.SqlFunctions.toBigDecimal(inputEnumerator.current());
return current == null ? (java.math.BigDecimal) null : - current;
}

`- current` is not right ,we'd better constructor a new BigDecimal object to to replace this code snippet，like 

return current == null ? (java.math.BigDecimal) null : SqlFunctions.negativeDecimal(current);

 

Issue Links

• depends upon: CALCITE-2861 Exception occurs when do arithmetic between decimal and other numeric types
• links to: GitHub Pull Request #1057