[CALCITE-2689] ES Adapter. Grouping on date / number fields fails

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.18.0
• Component/s: elasticsearch-adapter
• Assignee: Julian Hyde
• Reporter: Andrei Sereda
• Created: 20/Nov/18 23:48
• Updated: 20/Nov/21 01:30
• Resolved: 02/Dec/18 17:51

Description

For Terms Aggregation missing value has to have same type as group key:

select max(amount), date from orders group by date -- date column is of type date (in ES)

Currently single (text) key is used _MISSING_ which fails when grouping on non-string fields (eg. dates, numbers or booleans).

When using missing (value) query converter should consider field type.

This logic should be reviewed once we migrate to composite aggregations (available since 6.1 see PR26800)

Issue Links

• Blocked: CALCITE-4896 GROUP BY might get wrong results under certain circumstances in Elasticsearch Adapter
• links to: PR 946