[CALCITE-2591] EnumerableDefaults#mergeJoin should throw error and not return incorrect results when inputs are not ordered

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Component/s: core
• Assignee: Julian Hyde
• Reporter: Enrico Olivelli
• Created: 23/Sep/18 13:12
• Updated: 23/Dec/18 00:12
• Resolved: 24/Sep/18 21:02

Description

The merge join implementation should throw a runtime error in case of unsorted inputs.

 

The assertion  is already present but it is done with Java 'assert' keywork, this makes the assertion not to be evaluated in production.

It happened in production that due to a bug (out of the scope of this issue) a merge join was fed by an input which was not sorted according to the merge sort keys

This is current code in 1.17

int c = leftKey.compareTo(leftKey2);
        if (c != 0) {
          assert c < 0 : "not sorted";
          break;
        }

 

This change will enable that assertion even when Java assertions are not enabled.

The impact is not very significant (a few CPU cycles) but prevents invalid results to be returned by the query.