Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2559

Upgrade Checkstyle to 7.8.2

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.18.0
    • Component/s: None
    • Labels:
      None

      Description

      mvn clean validate for various:
       6.x  7.8.2 <-- checkstyle version
      19.7   18.3 <-- build time in seconds for all Calcite modules
      20.1   17.8
      20.0   17.6
      
      mvn org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check@validate:
       6.x  7.8.2 <-- checkstyle version
      8.91   4.19 <-- build time in seconds for all Calcite modules
      8.66   4.52
      8.38   3.49
      8.53   3.90
      8.32   3.80

      A side note: net.hydromatic.toolbox.checkstyle.HydromaticFileSetCheck is not compatible with Checkstyle 8.x

      Note: existing <property name="classes" value="java.lang.Boolean, java.lang.String"/> blocks use of new String(...) which is sometimes required to convert byte[] + encoding to String.
      I have added // CHECKSTYLE: IGNORE 0 in the relevant places, and I have no idea how it worked before.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vladimirsitnikov Vladimir Sitnikov
                Reporter:
                vladimirsitnikov Vladimir Sitnikov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: