[CALCITE-2559] Upgrade Checkstyle to 7.8.2

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.18.0
• Assignee: Vladimir Sitnikov
• Reporter: Vladimir Sitnikov
• Created: 16/Sep/18 10:21
• Updated: 23/Dec/18 00:12
• Resolved: 16/Sep/18 12:34

Description

mvn clean validate for various:
 6.x  7.8.2 <-- checkstyle version
19.7   18.3 <-- build time in seconds for all Calcite modules
20.1   17.8
20.0   17.6

mvn org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check@validate:
 6.x  7.8.2 <-- checkstyle version
8.91   4.19 <-- build time in seconds for all Calcite modules
8.66   4.52
8.38   3.49
8.53   3.90
8.32   3.80

A side note: net.hydromatic.toolbox.checkstyle.HydromaticFileSetCheck is not compatible with Checkstyle 8.x

Note: existing <property name="classes" value="java.lang.Boolean, java.lang.String"/> blocks use of new String(...) which is sometimes required to convert byte[] + encoding to String.
I have added // CHECKSTYLE: IGNORE 0 in the relevant places, and I have no idea how it worked before.

Issue Links

• is a clone of: CALCITE-2139 Upgrade checkstyle