Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2537

Make sure assertions are enabled before calling VolcanoPlanner#validate

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.18.0
    • Component/s: core
    • Labels:
      None

      Description

      VolcanoPlanner#validate() is invoked if the log level is debug or lower. But considering how enabling this method slows down the whole planning (changing it for running tests make the whole duration several hours), and this is some kind of assertion (since it throws AssertionError, I would suggest to only enable it when assertions are enabled

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                laurent Laurent Goujon
                Reporter:
                laurent Laurent Goujon
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: