Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2537

Make sure assertions are enabled before calling VolcanoPlanner#validate

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.18.0
    • Component/s: core
    • Labels:
      None

      Description

      VolcanoPlanner#validate() is invoked if the log level is debug or lower. But considering how enabling this method slows down the whole planning (changing it for running tests make the whole duration several hours), and this is some kind of assertion (since it throws AssertionError, I would suggest to only enable it when assertions are enabled

        Attachments

          Activity

            People

            • Assignee:
              laurent Laurent Goujon
              Reporter:
              laurent Laurent Goujon

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment