[CALCITE-2479] SqlAdvisor: automatically quote identifiers that look like SQL keywords

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Component/s: core
• Assignee: Julian Hyde
• Reporter: Vladimir Sitnikov
• Created: 19/Aug/18 15:47
• Updated: 23/Dec/18 00:12
• Resolved: 05/Sep/18 14:18

Description

Case for SqlAdvisorTest:

  @Test @WithLex(Lex.JAVA) public void testAdviceExpression() {
    String sql;
    sql = "select s.`count`+s.co^ from (select 1 `count` from emp) s";
    assertComplete(sql, "COLUMN(count)\n", "co",
        ImmutableMap.of("COLUMN(count)", "`count`"));
  }

It should automatically quote the suggested column name count since otherwise it is confused with count keyword.

Issue Links

• links to: PR 773