Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2449 RexSimplify overhaul
  3. CALCITE-2462

RexProgramTest: move "rex building" methods to base class

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.17.0
    • 1.18.0
    • core
    • None

    Description

      RexProgramTest is quite big (2000 lines now), and "easy to use" rex building is useful for many tests.

      So I suggest to move methods like gt, lt, etc to the base class, so multiple other tests can reuse it.

      Alternative option would be to use Kotlin for builders, yet I think Java tests will be there for quite a while, so it would be nice to simplify them as well.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            vladimirsitnikov Vladimir Sitnikov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment