[CALCITE-2434] SqlAdvisor.getCompletionHints does not work for nested identifiers sub-match

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Component/s: core
• Assignee: Vladimir Sitnikov
• Reporter: Vladimir Sitnikov
• Created: 31/Jul/18 18:17
• Updated: 23/Dec/18 00:12
• Resolved: 05/Sep/18 14:22

Description

Test (SqlAdvisorTest):

  @Test public void testNestSchema() throws Exception {
    String sql;
    sql = "select * from sales.n^";
    assertComplete(
        sql,
    ...);
}

Expected output: "SALES.NEST" schema and tables inside and so on
Actual output: empty.

The thing is it properly uses n for prefix search, however it uses hint.toString() and it fails for multi-name identifiers:

        // Regular identifier. Case-insensitive match.
        for (SqlMoniker hint : completionHints) {
          String cname = hint.toString();
          if ((cname.length() >= word.length())
              && cname.substring(0, word.length()).equalsIgnoreCase(word)) {
            result.add(hint);
          }
        }

Hints are like "CATALOG.SALES.NEST", and they fail cname.substring(0, word.length()).equalsIgnoreCase(word) check

Issue Links

• links to: PR 773