Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2365

Upgrade Calcite to Avatica 1.12

Rank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.17.0
    • None
    • None

    Description

      I guess the main reason is CALCITE-2219.
      tried to fix it here https://github.com/apache/calcite/compare/master...snuyanzin:CALCITE_AVATICA_12_UPDATE
      however there are at least 2 issues which are not fixed but only workarounded

      1. org.apache.calcite.test.LatticeTest#testGroupByEmpty3 connection pool factory is used however 3 methods (explainContains, and 2 returnsUnordered ) lead to org.apache.calcite.test.CalciteAssert#assertQuery which closes connections without paying attention if its from pool or not
      2. the same test. mats updated in explainplan and execute => that is why finally size is 6.
      3. test from core/src/test/resources/sql/misc.iq starts failing as the result of CALCITE-1884

      it would be nice to have some advice at least relating to first 2 bullets to fix it in a better way

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            Sergey Nuyanzin Sergey Nuyanzin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment