[CALCITE-2279] Druid adapter duplicate binary expression

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.27.0
• Component/s: druid-adapter
• Labels: pull-request-available
• Assignee: Nishant Bangarwa
• Reporter: Kevin Risden
• Created: 25/Apr/18 02:40
• Updated: 03/Jun/21 22:32
• Resolved: 18/Nov/20 10:11

Description

I was looking into Error Prone [1] checking for Calcite and it found what looks like a bug in Druid Adapter. The output is as follows
 

DruidJsonFilter.java:[324,9] [IdentityBinaryExpression] A binary expression where both operands are the same is usually incorrect; the value of this expression is equivalent to `lhs.getType().getFamily() == SqlTypeFamily.NUMERIC`.
[ERROR]     (see http://errorprone.info/bugpattern/IdentityBinaryExpression)

 
The DruidJsonFilter [2] has left and right hand the exact same.
 
[1] http://errorprone.info/
[2] https://github.com/apache/calcite/blob/master/druid/src/main/java/org/apache/calcite/adapter/druid/DruidJsonFilter.java#L323

Issue Links

• links to: GitHub Pull Request #678
• links to: PR