[CALCITE-2253] Fix matching predicate for JdbcProjectRule rule

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.17.0
• Component/s: jdbc-adapter
• Assignee: Julian Hyde
• Reporter: Vova Vysotskyi
• Created: 14/Apr/18 12:58
• Updated: 02/Oct/19 18:38
• Resolved: 16/Apr/18 07:11

Description

In CALCITE-2206 was prevented pushing windowed aggregates down for the SqlDialect s which do not support windowed functions.

After these changes, JdbcProjectRule is matched only for the cases when SqlDialect supports windowed functions and project contains windowed functions:

return out.dialect.supportsWindowFunctions()
    && !RexOver.containsOver(project.getProjects(), null);

It causes unit tests failures seen on the master.

Issue Links

• is related to: CALCITE-2206 JDBC adapter incorrectly pushes windowed aggregates down to HSQLDB