Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2253

Fix matching predicate for JdbcProjectRule rule

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.17.0
    • Component/s: jdbc-adapter
    • Labels:
      None

      Description

      In CALCITE-2206 was prevented pushing windowed aggregates down for the SqlDialect s which do not support windowed functions.

      After these changes, JdbcProjectRule is matched only for the cases when SqlDialect supports windowed functions and project contains windowed functions:

      return out.dialect.supportsWindowFunctions()
          && !RexOver.containsOver(project.getProjects(), null);
      

      It causes unit tests failures seen on the master.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                vvysotskyi Volodymyr Vysotskyi
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: