Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.17.0
    • Component/s: None
    • Labels:
      None

      Description

      lgtm.com has identified a number of places where the code can be improved by small changes. These include cases of

      • container contents never accessed (so the container can be removed)
      • reference equality test on boxed types (equals can be used instead)
      • type mismatch on container access (presumably checking for the wrong object)
      • boxed variable is never null (primitive type can be used instead)
      • dereferenced variable may be null (test for null should be added)
      • useless comparison test (the test can be removed)

      The analysis by lgtm.com can be viewed at https://lgtm.com/projects/g/apache/calcite/alerts . This issue is to address some of these alerts

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                malcolmt Malcolm Taylor
                Reporter:
                malcolmt Malcolm Taylor
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: