[CALCITE-2164] Fix alerts raised by lgtm.com

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.17.0
• Assignee: Malcolm Taylor
• Reporter: Malcolm Taylor
• Created: 04/Feb/18 11:56
• Updated: 20/Jul/18 08:18
• Resolved: 22/Apr/18 02:18

Description

lgtm.com has identified a number of places where the code can be improved by small changes. These include cases of

• container contents never accessed (so the container can be removed)
• reference equality test on boxed types (equals can be used instead)
• type mismatch on container access (presumably checking for the wrong object)
• boxed variable is never null (primitive type can be used instead)
• dereferenced variable may be null (test for null should be added)
• useless comparison test (the test can be removed)

The analysis by lgtm.com can be viewed at https://lgtm.com/projects/g/apache/calcite/alerts . This issue is to address some of these alerts

Issue Links

• links to: PR 621