Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2164

Fix alerts raised by lgtm.com

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.17.0
    • Component/s: None
    • Labels:
      None

      Description

      lgtm.com has identified a number of places where the code can be improved by small changes. These include cases of

      • container contents never accessed (so the container can be removed)
      • reference equality test on boxed types (equals can be used instead)
      • type mismatch on container access (presumably checking for the wrong object)
      • boxed variable is never null (primitive type can be used instead)
      • dereferenced variable may be null (test for null should be added)
      • useless comparison test (the test can be removed)

      The analysis by lgtm.com can be viewed at https://lgtm.com/projects/g/apache/calcite/alerts . This issue is to address some of these alerts

        Attachments

          Activity

            People

            • Assignee:
              malcolmt Malcolm Taylor
              Reporter:
              malcolmt Malcolm Taylor

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment