Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-209

Consistent strategy for line-endings in tests

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      A few older tests use `TestUtil.fold(String)` and `TestUtil.fold(String[])` to convert expected results with '\n' into os-dependent string.

      Newer tests use `Util.toLinux' to convert actual results with os-dependent line-endings into '\n'.

      There are 7 uses of `fold`; there are 14 uses of `toLinux` (many more indirect uses, via `checkResult` etc.)

      We should obsolete `fold` and convert tests to the `toLinux` style. Also review uses of `TestUtil.NL` and remove as many as possible - it would be nice to just use '\n'.

      ---------------- Imported from GitHub ----------------
      Url: https://github.com/julianhyde/optiq/issues/209
      Created by: julianhyde
      Labels:
      Assignee: julianhyde
      Created at: Tue Mar 25 20:28:30 CET 2014
      State: closed

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            github-import GitHub Import
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development