Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: None
    • Labels:
      None

      Description

      JDK 10 is in early access right now, but it's never too soon. Let's make sure that Calcite builds and runs on JDK 10, and add JDK 10 to the list of supported versions in history.md.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.15.0 (2017-12-11).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.15.0 (2017-12-11).
          Hide
          julianhyde Julian Hyde added a comment -

          Fixed in 0d10336a.

          Using JDK 10 early access release jdk-10-ea+32 on linux, code builds, tests and javadoc pass. Apache's Jenkins CI does not support JDK 10 yet (see CALCITE-2063), but we have nightly builds on Julian Hyde's private server.

          Show
          julianhyde Julian Hyde added a comment - Fixed in 0d10336a . Using JDK 10 early access release jdk-10-ea+32 on linux, code builds, tests and javadoc pass. Apache's Jenkins CI does not support JDK 10 yet (see CALCITE-2063 ), but we have nightly builds on Julian Hyde 's private server.
          Hide
          michaelmior Michael Mior added a comment -

          Julian Hyde My apologies, I didn't realize you were running the tests nightly. My concern was that we could end up in a situation where something was introduced which would be broken on JDK 10 and we wouldn't find out about it until several bits of new code had dependencies on it. If JDK 10 support is tested regularly, I definitely have no concerns.

          A separate issue for JDK 10 on Jenkins/Travis CI sounds good to me. Thanks again for your personal CI effort!

          Show
          michaelmior Michael Mior added a comment - Julian Hyde My apologies, I didn't realize you were running the tests nightly. My concern was that we could end up in a situation where something was introduced which would be broken on JDK 10 and we wouldn't find out about it until several bits of new code had dependencies on it. If JDK 10 support is tested regularly, I definitely have no concerns. A separate issue for JDK 10 on Jenkins/Travis CI sounds good to me. Thanks again for your personal CI effort!
          Hide
          julianhyde Julian Hyde added a comment -

          I disagree. I am regularly testing Calcite on JDK 10 (every night, via a cron job on my linux server) and it passes.

          I find it frustrating when no one is able to move to new software versions because everyone is waiting for everyone else to make the first move. By publicly declaring our support for JDK 10 we are doing our part to overcome this inertia. And, by the way, giving due credit to the JDK developers for maintaining stability.

          How about if I mark this case fixed, and open another to test it in ASF Jenkins and/or Travis?

          Show
          julianhyde Julian Hyde added a comment - I disagree. I am regularly testing Calcite on JDK 10 (every night, via a cron job on my linux server) and it passes. I find it frustrating when no one is able to move to new software versions because everyone is waiting for everyone else to make the first move. By publicly declaring our support for JDK 10 we are doing our part to overcome this inertia. And, by the way, giving due credit to the JDK developers for maintaining stability. How about if I mark this case fixed, and open another to test it in ASF Jenkins and/or Travis?
          Hide
          michaelmior Michael Mior added a comment -

          I would suggest leaving this open. I wouldn't really want to consider JDK 10 supported if we're not regularly testing it. I don't think there's a big downside to not publicly claiming JDK 10 support anyway since it's unlikely many are wanting it yet. I'm not sure how complicated is to configure on Jenkins. It will be easy on Travis once the webupd8 PPA publishes a package for it.

          Show
          michaelmior Michael Mior added a comment - I would suggest leaving this open. I wouldn't really want to consider JDK 10 supported if we're not regularly testing it. I don't think there's a big downside to not publicly claiming JDK 10 support anyway since it's unlikely many are wanting it yet. I'm not sure how complicated is to configure on Jenkins. It will be easy on Travis once the webupd8 PPA publishes a package for it.
          Hide
          julianhyde Julian Hyde added a comment -

          Josh Elser, Michael Mior, Since you two have taken most interest in CI, I'd like your opinion: do you think we should get CI (either ASF or Travis) working under JDK 10 before we declare victory on this one?

          I have this working using the CI on my home server (build, test, verify, site) and I think that's probably enough for now.

          Show
          julianhyde Julian Hyde added a comment - Josh Elser , Michael Mior , Since you two have taken most interest in CI, I'd like your opinion: do you think we should get CI (either ASF or Travis) working under JDK 10 before we declare victory on this one? I have this working using the CI on my home server (build, test, verify, site) and I think that's probably enough for now.

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development