Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2051

Rules using Aggregate might check for simple grouping sets incorrectly

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: core
    • Labels:
      None

      Description

      CALCITE-1069 removed the indicator columns for Aggregate operators. In some places, the indicator boolean check was replaced by the following check: aggregate.getGroupSets().size() > 1. However, that check is incomplete, it should have been replaced by aggregate.getGroupType() != Group.SIMPLE.

      For instance : https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/rules/AggregateProjectMergeRule.java#L91

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              jcamachorodriguez Jesus Camacho Rodriguez
              Reporter:
              jcamachorodriguez Jesus Camacho Rodriguez

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment