Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2037

Allow overriding of Calcite statements in Parser.jj

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: None
    • Labels:
      None

      Description

      Overriding of Calcite statements in parser can be very useful for some tasks in the future so I propose to move the next block:

          <#-- Add methods to parse additional statements here -->
          <#list parser.statementParserMethods as method>
                  stmt = ${method}
          </#list>
      

      on the top of the SqlStmt() method in Parser.jj to allow overriding of Calcite statements.

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.15.0 (2017-12-11).

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.15.0 (2017-12-11).
        Hide
        julianhyde Julian Hyde added a comment -

        Fixed in 5a0403cf; thanks for the PR, Roman Kulyk! (I added a test to our parser extension test so that this stays working.)

        Show
        julianhyde Julian Hyde added a comment - Fixed in 5a0403cf ; thanks for the PR, Roman Kulyk ! (I added a test to our parser extension test so that this stays working.)
        Show
        julianhyde Julian Hyde added a comment - Reviewing and testing https://github.com/apache/calcite/pull/561/commits/1d657069eaa49261b7e52f1ce3b8f6ee65067bcd now.
        Hide
        RomanKulyk Roman Kulyk added a comment -

        Created pull request 561.

        Show
        RomanKulyk Roman Kulyk added a comment - Created pull request 561 .

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            RomanKulyk Roman Kulyk
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development