Details

    • Type: Bug
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: spatial
    • Labels:
      None

      Description

      The initial set of OpenGIS functions were implemented in CALCITE-1968 but there are quite a few more to implement.

      Each function can be implemented separately, and with very little effort: you typically need to find the commented function in in spatial.iq (it will be followed by the comment # Not implemented), add one or two queries as test case, add a method to GeoFunctions.java, iterate until the test cases work, then add a row to one of the tables in reference.md to document that the function is now implemented.

      I suggest that each pull request implements a few related functions. A good place to start would be ST_X(geom); ST_Z(geom) is very similar and is already implemented.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          I didn't say you could get examples from H2GIS. They have documentation you can read to understand the purpose of particular functions. I find the documentation more complete than PostGIS documentation.

          Show
          julianhyde Julian Hyde added a comment - I didn't say you could get examples from H2GIS. They have documentation you can read to understand the purpose of particular functions. I find the documentation more complete than PostGIS documentation.
          Hide
          michaelmior Michael Mior added a comment -

          I implemented ST_X and ST_Y in 17cd76af7. As far as getting examples from H2GIS, if copy-paste is not permissible, then what is? Also, looking at the examples it seems like ST_Z (and also my implementations of ST_X and ST_Y) do not cover all the cases they should. They currently only work for points when the examples show them working for many other types.

          Show
          michaelmior Michael Mior added a comment - I implemented ST_X and ST_Y in 17cd76af7 . As far as getting examples from H2GIS, if copy-paste is not permissible, then what is? Also, looking at the examples it seems like ST_Z (and also my implementations of ST_X and ST_Y ) do not cover all the cases they should. They currently only work for points when the examples show them working for many other types.
          Hide
          julianhyde Julian Hyde added a comment -

          You can often find good, simple examples that can be turned into test cases on the PostGIS site; for example ST_X at PostGIS.

          H2GIS also has good documentation, for example ST_X at H2GIS, but you must not copy-paste examples from H2GIS because the license is not compatible with Apache.

          Show
          julianhyde Julian Hyde added a comment - You can often find good, simple examples that can be turned into test cases on the PostGIS site; for example ST_X at PostGIS . H2GIS also has good documentation, for example ST_X at H2GIS , but you must not copy-paste examples from H2GIS because the license is not compatible with Apache.
          Hide
          michaelmior Michael Mior added a comment -

          Sounds like a fun project to implement some of these. I'll take ST_X and ST_Y as a start.

          Show
          michaelmior Michael Mior added a comment - Sounds like a fun project to implement some of these. I'll take ST_X and ST_Y as a start.

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development