Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2014

Look for saffron.properties file in classpath rather then in working directory

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.14.0
    • Fix Version/s: 1.15.0
    • Component/s: None
    • Labels:
      None

      Description

      Calcite is using several saffron properties.
      There are two ways to set them:
      1. as system property;
      2. using saffron.properties file.

      Using saffron.properties file is very convenient when you need to set several properties at a time. In code saffron.properties location is expected to be working folder, i.e. the place where java process was started.

      For production systems it would much better is saffron.properties file was expected to be present in classpath rather then in working directory.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.15.0 (2017-12-11).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.15.0 (2017-12-11).
          Hide
          arina Arina Ielchiieva added a comment -

          Julian Hyde thanks for the code review!

          Show
          arina Arina Ielchiieva added a comment - Julian Hyde thanks for the code review!
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/534b09ff ; thanks for the PR, Arina Ielchiieva !
          Show
          julianhyde Julian Hyde added a comment - Reviewing https://github.com/apache/calcite/pull/550/commits/7a142cd86c95bd830326c2aa56342514e7f7f336 now.
          Hide
          arina Arina Ielchiieva added a comment -

          Created pull request - https://github.com/apache/calcite/pull/550, please review.

          Show
          arina Arina Ielchiieva added a comment - Created pull request - https://github.com/apache/calcite/pull/550 , please review.

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              arina Arina Ielchiieva
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development