Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2012

Replace LocalInterval by Interval in Druid adapter

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.14.0
    • Fix Version/s: 1.15.0
    • Component/s: druid
    • Labels:
      None

      Description

      CALCITE-1617 introduced LocalInterval as a proper way to close the gap between the semantics of SQL timestamp type and Druid instants.

      After that, CALCITE-1947 introduced 'timestamp with local time zone' type in Calcite and mapped the Druid time column to this type. Thus, we do not need anymore the LocalInterval class and we can use Joda Interval, since the column represents an Instant rather than a LocalDateTime.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.15.0 (2017-12-11).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.15.0 (2017-12-11).
          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -
          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Julian Hyde , patch was in fact ready. Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/20ade9d .
          Hide
          julianhyde Julian Hyde added a comment -

          Jesus Camacho Rodriguez, Is this PR ready for review? Do you think this will be ready for code freeze on Nov 27?

          Show
          julianhyde Julian Hyde added a comment - Jesus Camacho Rodriguez , Is this PR ready for review? Do you think this will be ready for code freeze on Nov 27?
          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - https://github.com/jcamachor/calcite/tree/CALCITE-2012

            People

            • Assignee:
              jcamachorodriguez Jesus Camacho Rodriguez
              Reporter:
              jcamachorodriguez Jesus Camacho Rodriguez
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development