Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1998

Hive - Version specific handling for NULLS FIRST/ NULLS LAST

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.15.0
    • 1.15.0
    • core
    • None

    Description

      This JIRA is for PR https://github.com/apache/calcite/pull/545

      We are making the HiveSqlDialect version aware for the NULLS FIRST and NULLS LAST feature. In https://issues.apache.org/jira/browse/HIVE-12994 , the authors clarified that the default NullCollation for Hive is "NullDirection.LOW". Currently, the DEFAULT set in Calcite for Hive is NullCollation.HIGH

      In this PR, we are making 2 changes.

      1. Change the default NullCollation from HIGH to LOW
      2. Add NullCollation emulation in the HiveSqlDialect when the version of the dialect is less that 2.1.0 or when the version is blank.

      We're also adding a new Dialect "BigQuerySqlDialect" with the "quoteString" as "`" based on https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            julianhyde Julian Hyde
            nerrve Abbas Gadhia
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment