Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.15.0
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      julianhyde Julian Hyde added a comment -

      Resolved in release 1.15.0 (2017-12-11).

      Show
      julianhyde Julian Hyde added a comment - Resolved in release 1.15.0 (2017-12-11).
      Show
      julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/8441e79c .
      Hide
      julianhyde Julian Hyde added a comment - - edited

      The issues are described in a patch that I plan to push to master right after 1.14:

      • Fix error that SqlNode.clone does not call super.clone; deprecate
        it, and add SqlNode.clone(SqlNode)
      • Fix error that NlsString.clone does not call super.clone
      • Make AggregateNode.AccumulatorList static, because non-static inner
        classes must not implement Serializable
      • Change XmlOutput.content to not use LineNumberReader.readLine, which
        is susceptible to a DoS attack

      I agree that a review of Coverity output would be good. It's out of scope of this bug, though.

      Show
      julianhyde Julian Hyde added a comment - - edited The issues are described in a patch that I plan to push to master right after 1.14: Fix error that SqlNode.clone does not call super.clone; deprecate it, and add SqlNode.clone(SqlNode) Fix error that NlsString.clone does not call super.clone Make AggregateNode.AccumulatorList static, because non-static inner classes must not implement Serializable Change XmlOutput.content to not use LineNumberReader.readLine, which is susceptible to a DoS attack I agree that a review of Coverity output would be good. It's out of scope of this bug, though.
      Hide
      michaelmior Michael Mior added a comment - - edited

      Not sure what the scope of this is, but it would good to have a more thorough review of the Coverity results.

      Show
      michaelmior Michael Mior added a comment - - edited Not sure what the scope of this is, but it would good to have a more thorough review of the Coverity results.

        People

        • Assignee:
          julianhyde Julian Hyde
          Reporter:
          julianhyde Julian Hyde
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development