[CALCITE-1976] makeLiteral(Arrays.asList(...), structType, allowCast=any) does not work for Enumerable

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.13.0
• Fix Version/s: 1.15.0
• Component/s: core
• Assignee: Julian Hyde
• Reporter: Vladimir Sitnikov
• Created: 08/Sep/17 11:10
• Updated: 09/Dec/17 18:21
• Resolved: 02/Oct/17 21:01

Description

org.apache.calcite.adapter.enumerable.RexToLixTranslator#translateLiteral creates ConstantExpression with List contents, and org.apache.calcite.linq4j.tree.ConstantExpression#write just misses a case for List/Map, thus it resorts to plain toString and produces the following code:

            public Object current() {
              final org.eclipse.mat.snapshot.model.IObject v0 = com.github.vlsi.mat.calcite.functions.ISnapshotMethods.getIObject(com.github.vlsi.mat.calcite.SnapshotHo
              return new Object[] {
                  com.github.vlsi.mat.calcite.functions.ISnapshotMethods.toReference(v0),
                  [0, 1], <-- does not compile
                  org.apache.calcite.runtime.SqlFunctions.toFloat(com.github.vlsi.mat.calcite.functions.IObjectMethods.resolveSimpleValue(v0, "loadFactor")),
...