Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1925

JaninoRelMetadataProvider to cache null value

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.13.0
    • Fix Version/s: 1.14.0
    • Component/s: core
    • Labels:
      None

      Description

      JaninoRelMetadataProvider should cache null value to improve performance.

        Activity

        Hide
        michaelmior Michael Mior added a comment -

        Resolved in release 1.14.0 (2017-10-01)

        Show
        michaelmior Michael Mior added a comment - Resolved in release 1.14.0 (2017-10-01)
        Hide
        tedxu Ted Xu added a comment -

        Thanks Julian Hyde!

        Show
        tedxu Ted Xu added a comment - Thanks Julian Hyde !
        Hide
        julianhyde Julian Hyde added a comment -
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/eaa56413 . Thanks for the PR, Ted Xu !
        Hide
        julianhyde Julian Hyde added a comment -

        I agree, a test is hard in this case. We can skip. Reviewing and testing now.

        Show
        julianhyde Julian Hyde added a comment - I agree, a test is hard in this case. We can skip. Reviewing and testing now.
        Hide
        tedxu Ted Xu added a comment -

        It's a bit hard to create a unit test. Julian Hyde could you please have a look at my pull request?

        Show
        tedxu Ted Xu added a comment - It's a bit hard to create a unit test. Julian Hyde could you please have a look at my pull request?
        Hide
        tedxu Ted Xu added a comment -

        Here https://github.com/apache/calcite/pull/507 is a rough showcase. I'll try if I can create a test.

        Show
        tedxu Ted Xu added a comment - Here https://github.com/apache/calcite/pull/507 is a rough showcase. I'll try if I can create a test.

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            tedxu Ted Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development