Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1883

HepPlanner should force garbage collect whenever a root registered

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.14.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently HepPlanner#collectGarbage() will skip if there is no new transform since last GC. If HepPlanner is reused, it is common case that no transform is applied after last cheapest plan is built while before next round of optimize is kicked off.

      This may break HepPlanner because the garbage is probably not a graph after HepPlanner#buildFinalPlan .

      I'll try if I can create a reproduce case.

        Activity

        Hide
        michaelmior Michael Mior added a comment -

        Resolved in release 1.14.0 (2017-10-01)

        Show
        michaelmior Michael Mior added a comment - Resolved in release 1.14.0 (2017-10-01)
        Hide
        julianhyde Julian Hyde added a comment -
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/eb911cb5 . Thanks for sorting out the PR, Ted Xu !
        Hide
        tedxu Ted Xu added a comment -

        Thanks Julian Hyde, the pull request is updated.

        That is actually me, sorry for my misconfiguring of git properties.

        Show
        tedxu Ted Xu added a comment - Thanks Julian Hyde , the pull request is updated. That is actually me, sorry for my misconfiguring of git properties.
        Hide
        julianhyde Julian Hyde added a comment -

        The change looks good, and I would like to commit it.

        However, you (Ted Xu) do not seem to be the author of the change, so I'm not sure I can accept the pull request.

        Show
        julianhyde Julian Hyde added a comment - The change looks good, and I would like to commit it. However, you ( Ted Xu ) do not seem to be the author of the change, so I'm not sure I can accept the pull request.
        Hide
        tedxu Ted Xu added a comment -

        Julian Hyde I've issued a pull request here: https://github.com/apache/calcite/pull/497

        I'm not sure if the fix (leveraging the idea of number of transformations) is good enough, but you can reproduce the bug from that test case.

        Show
        tedxu Ted Xu added a comment - Julian Hyde I've issued a pull request here: https://github.com/apache/calcite/pull/497 I'm not sure if the fix (leveraging the idea of number of transformations) is good enough, but you can reproduce the bug from that test case.

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            tedxu Ted Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development