Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1834

Implement precedence list for Array and Multiset

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.14.0
    • Component/s: core
    • Labels:
      None

      Description

      Arrays and Multisets can have precedence according to the precedence of its component type.

        Issue Links

          Activity

          Hide
          michaelmior Michael Mior added a comment -

          Resolved in release 1.14.0 (2017-10-01)

          Show
          michaelmior Michael Mior added a comment - Resolved in release 1.14.0 (2017-10-01)
          Hide
          julianhyde Julian Hyde added a comment -

          I'm not sure how snapshots are supposed to be built. They're probably built on Jenkins not Travis.

          Show
          julianhyde Julian Hyde added a comment - I'm not sure how snapshots are supposed to be built. They're probably built on Jenkins not Travis.
          Hide
          ankit@apache.org Ankit Singhal added a comment - - edited

          Julian Hyde, it seems the build failed [1] with the flaking test (CsvTest#testCsvStream which failed earlier also in build#1042), may be 10 sec is not enough.
          can you please restart the build again currently phoenix-calcite build is failing because snapshot jar is not available.

          [ERROR] Failed to execute goal on project phoenix-core: Could not resolve dependencies for project org.apache.phoenix:phoenix-core:jar:4.11.0-HBase-1.2-SNAPSHOT: Could not find artifact org.apache.calcite:calcite-core:jar:1.14.0-20170702.090030-5 in apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
          

          [1] https://travis-ci.org/apache/calcite/builds/249281558

          Show
          ankit@apache.org Ankit Singhal added a comment - - edited Julian Hyde , it seems the build failed [1] with the flaking test (CsvTest#testCsvStream which failed earlier also in build#1042), may be 10 sec is not enough. can you please restart the build again currently phoenix-calcite build is failing because snapshot jar is not available. [ERROR] Failed to execute goal on project phoenix-core: Could not resolve dependencies for project org.apache.phoenix:phoenix-core:jar:4.11.0-HBase-1.2-SNAPSHOT: Could not find artifact org.apache.calcite:calcite-core:jar:1.14.0-20170702.090030-5 in apache.snapshots (http: //repository.apache.org/snapshots) -> [Help 1] [1] https://travis-ci.org/apache/calcite/builds/249281558
          Hide
          ankit@apache.org Ankit Singhal added a comment -

          Thanks Julian Hyde for the review.

          Show
          ankit@apache.org Ankit Singhal added a comment - Thanks Julian Hyde for the review.
          Hide
          julianhyde Julian Hyde added a comment -
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/319e888f . Thanks for the PR, Ankit Singhal !
          Hide
          julianhyde Julian Hyde added a comment - - edited

          I made a couple of changes:

          • Removed the type factory from the function. Parameters are supposed to be lambdas that create types when given a type factory.
          • I converted a couple of assert statements to if ... throw. Otherwise the test would fail if asserts were disabled.

          Looks good, nice work, testing now, will commit soon.

          Show
          julianhyde Julian Hyde added a comment - - edited I made a couple of changes: Removed the type factory from the function. Parameters are supposed to be lambdas that create types when given a type factory. I converted a couple of assert statements to if ... throw . Otherwise the test would fail if asserts were disabled. Looks good, nice work, testing now, will commit soon.
          Hide
          julianhyde Julian Hyde added a comment -

          I see you've added test cases. I'll review today.

          Show
          julianhyde Julian Hyde added a comment - I see you've added test cases. I'll review today.
          Hide
          julianhyde Julian Hyde added a comment -

          Can you give one SQL statement that fails without this code change and succeeds with it? Otherwise this test is so complex and low-level and it will very like get broken in maintenance in the next year or two and no one will notice.

          Show
          julianhyde Julian Hyde added a comment - Can you give one SQL statement that fails without this code change and succeeds with it? Otherwise this test is so complex and low-level and it will very like get broken in maintenance in the next year or two and no one will notice.

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              ankit@apache.org Ankit Singhal
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development