[CALCITE-1826] Jdbc dialect specific FLOOR fails when in GROUP BY

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Component/s: jdbc-adapter
• Assignee: Julian Hyde
• Reporter: Chris Baynes
• Created: 02/Jun/17 09:24
• Updated: 02/Oct/17 14:30
• Resolved: 06/Jul/17 23:19

Description

Currently the SqlFloorFunction sometimes modifies the operands in a SqlCall (i.e. replaceTimeUnitOperand). This is fine if the floor is only used in a project, but when used again in an aggregate this modification will change the aggregate, which will break the unparsing of it there.

This can be reproduced by adding a "group by" to the RelToSqlConverterTest#testFloor.

SqlBasicCall#clone is a shallow clone so cannot be used to fix the problem (since the underlying operands are not cloned).

Issue Links

• links to: PR 489