Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1782

AggregateExpandDistinctAggregatesRule should work on Aggregate instead of LogicalAggregate

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.13.0
    • Component/s: None
    • Labels:
      None

      Description

      AggregateExpandDistinctAggregatesRule expects the operator to be a subclass of LogicalAggregate:

        public AggregateExpandDistinctAggregatesRule(
            Class<? extends LogicalAggregate> clazz,
            RelFactories.JoinFactory joinFactory) {
          this(clazz, false, RelBuilder.proto(Contexts.of(joinFactory)));
        }
      

      However, LogicalAggregate is a final class which cannot be inherited. This jira proposes to change the signature from LogicalAggregate to Aggregate.

        Attachments

          Activity

            People

            • Assignee:
              wheat9 Haohui Mai
              Reporter:
              wheat9 Haohui Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: