Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.13.0
-
Component/s: None
-
Labels:None
Description
AggregateExpandDistinctAggregatesRule expects the operator to be a subclass of LogicalAggregate:
public AggregateExpandDistinctAggregatesRule(
Class<? extends LogicalAggregate> clazz,
RelFactories.JoinFactory joinFactory) {
this(clazz, false, RelBuilder.proto(Contexts.of(joinFactory)));
}
However, LogicalAggregate is a final class which cannot be inherited. This jira proposes to change the signature from LogicalAggregate to Aggregate.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Sounds fine. But you should modify the non-deprecated constructor, which takes a RelBuilderFactory argument, rather than the deprecated one which takes a RelFactories.JoinFactory.
I saw your PR https://github.com/apache/calcite/pull/447. Please update the comments in that file.
Please read & consider revising all comments in the file. There are several more occurrences of LogicalAggregate (and LogicalJoin) in comments.
Reviewing now. Fixing the comments you missed. Sigh.
Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/ac364e8c. Thanks for the PR, Haohui Mai!
Resolved in release 1.13.0 (2017-06-26).
This issue prevents Flink from applying the same rule to optimize for streaming query, where the streaming aggregate operator is a subclass of Aggregate.