Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1746

Remove KEYS file from git and from release tar ball

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: avatica-1.10.0, 1.13.0
    • Component/s: avatica, site
    • Labels:
      None

      Description

      Remove KEYS file from git repo, and from their release tar balls.

      The definitive KEYS file is the one in subversion, viz https://dist.apache.org/repos/dist/release/calcite. Having a KEYS file in the git repo is redundant, misleading, and potentially dangerous: if a git repo or release tar ball is compromised then its KEYS file may be compromised.

      This applies to both Calcite and Avatica.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          By the way, currently Calcite's and Avatica's KEYS files are identical to that in svn.

          Show
          julianhyde Julian Hyde added a comment - By the way, currently Calcite's and Avatica's KEYS files are identical to that in svn.
          Show
          julianhyde Julian Hyde added a comment - Josh Elser , Please review https://github.com/julianhyde/calcite/tree/1746-remove-keys and https://github.com/julianhyde/calcite-avatica/tree/1746-remove-keys .
          Hide
          elserj Josh Elser added a comment -

          +1 thanks, Julian!

          Show
          elserj Josh Elser added a comment - +1 thanks, Julian!
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite-avatica/commit/01ec8834 (avatica) and http://git-wip-us.apache.org/repos/asf/calcite/commit/35cd2abc (calcite).
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release avatica-1.10.0 (2017-05-30).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release avatica-1.10.0 (2017-05-30).

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development