Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1725

Push project aggregate of time extract to druid

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.13.0
    • Component/s: druid
    • Labels:
      None

      Description

      Push aggs on Extract (Year/Month/Day) as Extraction function to druid.
      Avoid usage of granularity NONE by adding time extract instead.

        Activity

        Show
        bslim slim bouguerra added a comment - https://github.com/apache/calcite/pull/412
        Hide
        bslim slim bouguerra added a comment -
        Show
        bslim slim bouguerra added a comment - CC Jesus Camacho Rodriguez
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/ef03b6e and http://git-wip-us.apache.org/repos/asf/calcite/commit/04c0c8b.

        Second commit contains some fixes to avoid name collisions in the column names for EXTRACT functions, issue with CAST, and style changes in DruidAdapterIT.

        Thanks slim bouguerra!

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/ef03b6e and http://git-wip-us.apache.org/repos/asf/calcite/commit/04c0c8b . Second commit contains some fixes to avoid name collisions in the column names for EXTRACT functions, issue with CAST, and style changes in DruidAdapterIT. Thanks slim bouguerra !
        Hide
        julianhyde Julian Hyde added a comment -

        Can you fix the hanging close parentheses? They are inconsistent with Calcite code style. " )" does not occur elsewhere in Calcite.

        The javadoc comments are not very informative. Mostly they seem to just write the name of the class or interface. But they don't actually explain what a "dimension specification" or "extraction function" is.

        Show
        julianhyde Julian Hyde added a comment - Can you fix the hanging close parentheses? They are inconsistent with Calcite code style. " )" does not occur elsewhere in Calcite. The javadoc comments are not very informative. Mostly they seem to just write the name of the class or interface. But they don't actually explain what a "dimension specification" or "extraction function" is.
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        Julian Hyde, I had fixed those hanging close parenthesis in: http://git-wip-us.apache.org/repos/asf/calcite/commit/04c0c8b , did I miss any?

        I will add some comments to those classes in a follow-up commit.

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Julian Hyde , I had fixed those hanging close parenthesis in: http://git-wip-us.apache.org/repos/asf/calcite/commit/04c0c8b , did I miss any? I will add some comments to those classes in a follow-up commit.
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -
        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Included additional comments in: http://git-wip-us.apache.org/repos/asf/calcite/commit/2eebca8 .
        Hide
        julianhyde Julian Hyde added a comment -

        Thanks Jesus Camacho Rodriguez – all looks good!

        Show
        julianhyde Julian Hyde added a comment - Thanks Jesus Camacho Rodriguez – all looks good!
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        Last fix-up, there was a test failing but did not caught that in the DruidAdapterIT run before commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/e76d5ee .

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Last fix-up, there was a test failing but did not caught that in the DruidAdapterIT run before commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/e76d5ee .
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        Resolved in release 1.13.0 (2017-06-26).

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.13.0 (2017-06-26).

          People

          • Assignee:
            bslim slim bouguerra
            Reporter:
            bslim slim bouguerra
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development