Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1714

Do not push group by on druid metrics fields

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.12.0
    • Fix Version/s: 1.13.0
    • Component/s: druid
    • Labels:
      None

      Description

      Druid does not support grouping by metrics, hence we can not push the group by to druid. Instead we should generate a select query.

        Activity

        Show
        bslim slim bouguerra added a comment - https://github.com/apache/calcite/pull/409
        Hide
        julianhyde Julian Hyde added a comment -

        Can you add a test?

        Show
        julianhyde Julian Hyde added a comment - Can you add a test?
        Hide
        bslim slim bouguerra added a comment -

        done

        Show
        bslim slim bouguerra added a comment - done
        Hide
        gian Gian Merlino added a comment -

        Druid 0.10.0 will support grouping by numeric columns, fwiw.

        Show
        gian Gian Merlino added a comment - Druid 0.10.0 will support grouping by numeric columns, fwiw.
        Hide
        gian Gian Merlino added a comment -

        (master already does)

        Show
        gian Gian Merlino added a comment - (master already does)
        Hide
        bslim slim bouguerra added a comment -

        Gian Merlino we are not there yet, all the hive integration is bundled with the released version of druid.

        Show
        bslim slim bouguerra added a comment - Gian Merlino we are not there yet, all the hive integration is bundled with the released version of druid.
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        slim bouguerra, last PR looks good, thanks. Let's wait for the 1.12.0 release vote to be done and I will merge the changes into master.

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - slim bouguerra , last PR looks good, thanks. Let's wait for the 1.12.0 release vote to be done and I will merge the changes into master.
        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/0209b16 . Thanks slim bouguerra !
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        Resolved in release 1.13.0 (2017-06-26).

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Resolved in release 1.13.0 (2017-06-26).

          People

          • Assignee:
            bslim slim bouguerra
            Reporter:
            bslim slim bouguerra
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development