Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.12.0
    • Component/s: None
    • Labels:
      None

      Description

      came as part of discussion for https://issues.apache.org/jira/browse/HIVE-15619

      Druid specific rules will match DruidQuery at the leaf node, e.g., for ProjectFilterTransposeRule Project-Filter-DruidQuery

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          There are checkstyle errors. Can you fix them please. Also, even though checkstyle doesn't check this, can you indent function arguments 4. Not align with the open parenthesis.

          When you add a constructor for a rule, make sure that RelBuilderFactory relBuilderFactory is one of the arguments. Pass in RelFactories.LOGICAL_BUILDER if your particular rule instance wants the default factory.

          Make sure that only one of the constructors calls super(...); all other constructors should call this(...). Therefore there's only one place that you need to place a breakpoint. (Scala enforces this, and sadly Java/checkstyle do not, but it is part of our house style.)

          Show
          julianhyde Julian Hyde added a comment - There are checkstyle errors. Can you fix them please. Also, even though checkstyle doesn't check this, can you indent function arguments 4. Not align with the open parenthesis. When you add a constructor for a rule, make sure that RelBuilderFactory relBuilderFactory is one of the arguments. Pass in RelFactories.LOGICAL_BUILDER if your particular rule instance wants the default factory. Make sure that only one of the constructors calls super(...) ; all other constructors should call this(...) . Therefore there's only one place that you need to place a breakpoint. (Scala enforces this, and sadly Java/checkstyle do not, but it is part of our house style.)
          Hide
          nishantbangarwa Nishant Bangarwa added a comment -

          Julian Hyde Jesus Camacho Rodriguez handled review comments.

          Show
          nishantbangarwa Nishant Bangarwa added a comment - Julian Hyde Jesus Camacho Rodriguez handled review comments.
          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Pushed in http://git-wip-us.apache.org/repos/asf/calcite/commit/cdc1d96 . Thanks Nishant Bangarwa !
          Hide
          julianhyde Julian Hyde added a comment -

          Nishant Bangarwa, In DruidProjectFilterTransposeRule there isn't a DruidQuery operand. It will run on all Project/Filter pairs throughout the RelNode tree. Is that what you intended?

          Show
          julianhyde Julian Hyde added a comment - Nishant Bangarwa , In DruidProjectFilterTransposeRule there isn't a DruidQuery operand. It will run on all Project/Filter pairs throughout the RelNode tree. Is that what you intended?
          Hide
          nishantbangarwa Nishant Bangarwa added a comment -

          Julian Hyde thanks for pointing it out, have created a follow up PR - https://github.com/apache/calcite/pull/407

          Show
          nishantbangarwa Nishant Bangarwa added a comment - Julian Hyde thanks for pointing it out, have created a follow up PR - https://github.com/apache/calcite/pull/407
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.12.0 (2017-03-24).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.12.0 (2017-03-24).

            People

            • Assignee:
              nishantbangarwa Nishant Bangarwa
              Reporter:
              nishantbangarwa Nishant Bangarwa
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development