Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1621

Adding a cast around the null literal in aggregate rules

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.0
    • Fix Version/s: 1.12.0
    • Component/s: None
    • Labels:
      None

      Description

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.12.0 (2017-03-24).

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.12.0 (2017-03-24).
          Hide
          julianhyde Julian Hyde added a comment -
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/d6093f08 . Thanks for the PR, Anton Mushin !
          Hide
          anmu Anton Mushin added a comment - - edited

          Hello Julian Hyde,
          I updated PR. I added test cases for cast in AggregateExpandDistinctAggregatesRule and AggregateReduceFunctionsRule.
          I don't know how I can check cast null literal in AggregateValuesRule because the rule works with result null literal and I get

          LogicalValues(tuples=[[{ 0, null }]])

          in result plan for select count( * ), sum(empno) from emp where false

          Show
          anmu Anton Mushin added a comment - - edited Hello Julian Hyde , I updated PR. I added test cases for cast in AggregateExpandDistinctAggregatesRule and AggregateReduceFunctionsRule . I don't know how I can check cast null literal in AggregateValuesRule because the rule works with result null literal and I get LogicalValues(tuples=[[{ 0, null }]]) in result plan for select count( * ), sum(empno) from emp where false
          Hide
          julianhyde Julian Hyde added a comment -

          Can you please add a test case?

          Show
          julianhyde Julian Hyde added a comment - Can you please add a test case?

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              anmu Anton Mushin
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development