[CALCITE-1608] Move addMonths and subtractMonths from Calcite to Avatica

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: avatica
• Assignee: Unassigned
• Reporter: Julian Hyde
• Created: 27/Jan/17 20:54
• Updated: 23/Oct/22 14:59
• Resolved: 28/Jan/17 17:03

Description

Move the addMonths and subtractMonths methods from Calcite's SqlFunctions to Avatica's DateTimeUtils. This is consistent with other date-time functions being in Avatica.

Also, move tests from Calcite SqlFunctionsTest to Avatica DateTimeUtilsTest.

After they are in an Avatica release that Calcite uses (see CALCITE-1612), we can remove from Calcite and also get some extra functionality (see CALCITE-1613).

Issue Links

• causes: CALCITE-3078 Move public lastDay method from Calcite to Avatica
• is depended upon by: CALCITE-1609 Implement unixDateExtract and timeExtract for more time units
• is depended upon by: CALCITE-1613 Implement EXTRACT for time unit DOW, DOY; and fix CENTURY