Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1575

Literals may lose precision during expression reduction

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.10.0, 1.11.0
    • Fix Version/s: 1.12.0
    • Component/s: core
    • Labels:
      None
    1. CALCITE-1575.patch
      1 kB
      Ashutosh Chauhan
    2. CALCITE-1575.3.patch
      4 kB
      Ashutosh Chauhan
    3. CALCITE-1575.2.patch
      1 kB
      Ashutosh Chauhan

      Activity

      Hide
      julianhyde Julian Hyde added a comment -

      Need a test case, and it causes 6 failures.

      Show
      julianhyde Julian Hyde added a comment - Need a test case, and it causes 6 failures.
      Hide
      ashutoshc Ashutosh Chauhan added a comment -

      Fixed test failures.

      Show
      ashutoshc Ashutosh Chauhan added a comment - Fixed test failures.
      Show
      jcamachorodriguez Jesus Camacho Rodriguez added a comment - - edited Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/bb80d98 . Thanks Ashutosh Chauhan !
      Hide
      julianhyde Julian Hyde added a comment - - edited

      Thanks for reviewing, Jesus Camacho Rodriguez. I force-pushed a minor change to the commit message, because we don't append names of contributors who are committers (whether or not they commit their own patch). (Yeah, I know, pedantic.)

      New commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/010f7abb

      The same issue may exist for scale. I'll try to extend Ashutosh Chauhan's test case and see whether there's a problem.

      Show
      julianhyde Julian Hyde added a comment - - edited Thanks for reviewing, Jesus Camacho Rodriguez . I force-pushed a minor change to the commit message, because we don't append names of contributors who are committers (whether or not they commit their own patch). (Yeah, I know, pedantic.) New commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/010f7abb The same issue may exist for scale. I'll try to extend Ashutosh Chauhan 's test case and see whether there's a problem.
      Hide
      julianhyde Julian Hyde added a comment -

      Ashutosh Chauhan, Jesus Camacho Rodriguez, The test case does not exercise the new code. It does not even call the gatherConstraints method.

      Show
      julianhyde Julian Hyde added a comment - Ashutosh Chauhan , Jesus Camacho Rodriguez , The test case does not exercise the new code. It does not even call the gatherConstraints method.
      Hide
      jcamachorodriguez Jesus Camacho Rodriguez added a comment -

      Julian Hyde, I reviewed the code and checked the test case, thinking that we were hitting the code. Also I run the testsuite. But I did not run test case w/o changes before pushing it. Sorry about that.

      Show
      jcamachorodriguez Jesus Camacho Rodriguez added a comment - Julian Hyde , I reviewed the code and checked the test case, thinking that we were hitting the code. Also I run the testsuite. But I did not run test case w/o changes before pushing it. Sorry about that.
      Hide
      julianhyde Julian Hyde added a comment -

      Resolved in release 1.12.0 (2017-03-24).

      Show
      julianhyde Julian Hyde added a comment - Resolved in release 1.12.0 (2017-03-24).

        People

        • Assignee:
          julianhyde Julian Hyde
          Reporter:
          ashutoshc Ashutosh Chauhan
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development