Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      A few tests are currently failing intermittently.

      1. UdfTest

      UdfTest.testUserDefinedFunction:162 
      Expected: is <9>
          but: was <10>
      

      2. StreamTest.testInfiniteStreamsDoNotBufferInMemory

      FAILURE! - in org.apache.calcite.test.StreamTest
      testInfiniteStreamsDoNotBufferInMemory(org.apache.calcite.test.StreamTest)
      Time elapsed: 0.218 sec  <<< ERROR!
      java.lang.RuntimeException: exception while executing [select stream * from
      orders]
      at
      org.apache.calcite.test.StreamTest.testInfiniteStreamsDoNotBufferInMemory(StreamTest.java:237)
      Caused by: java.util.NoSuchElementException
      at
      org.apache.calcite.test.StreamTest.testInfiniteStreamsDoNotBufferInMemory(StreamTest.java:237)
      

      I don't consider any of them serious – they are test issues, not product correctness issues – but they are inconvenient because false negatives waste developer time.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          3. CalciteRemoteDriverTest.testRemoteExecuteQuery2 (under JDK9)

          Running org.apache.calcite.jdbc.CalciteRemoteDriverTest
          Tests run: 27, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.558 sec <<< FAILURE! - in org.apache.calcite.jdbc.CalciteRemoteDriverTest
          testRemoteExecuteQuery2(org.apache.calcite.jdbc.CalciteRemoteDriverTest)  Time elapsed: 0.063 sec  <<< ERROR!
          org.apache.calcite.avatica.AvaticaSqlException: Error -1 (00000) : Error while executing SQL "values (1, 'a'), (cast(null as integer), 'b')": Remote driver error: RuntimeException: org.apache.calcite.avatica.NoSuchStatementException -> NoSuchStatementException: (null exception message)
                  at org.apache.calcite.jdbc.CalciteRemoteDriverTest.testRemoteExecuteQuery2(CalciteRemoteDriverTest.java:296)
          
          Show
          julianhyde Julian Hyde added a comment - 3. CalciteRemoteDriverTest.testRemoteExecuteQuery2 (under JDK9) Running org.apache.calcite.jdbc.CalciteRemoteDriverTest Tests run: 27, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.558 sec <<< FAILURE! - in org.apache.calcite.jdbc.CalciteRemoteDriverTest testRemoteExecuteQuery2(org.apache.calcite.jdbc.CalciteRemoteDriverTest) Time elapsed: 0.063 sec <<< ERROR! org.apache.calcite.avatica.AvaticaSqlException: Error -1 (00000) : Error while executing SQL "values (1, 'a'), (cast(null as integer), 'b')": Remote driver error: RuntimeException: org.apache.calcite.avatica.NoSuchStatementException -> NoSuchStatementException: (null exception message) at org.apache.calcite.jdbc.CalciteRemoteDriverTest.testRemoteExecuteQuery2(CalciteRemoteDriverTest.java:296)
          Hide
          julianhyde Julian Hyde added a comment -

          4. PigRelBuilderStyleTest.testImplWithGroupByCountDistinct

          Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.925 sec <<< FAILURE! - in org.apache.calcite.test.PigRelBuilderStyleTest
          testImplWithGroupByCountDistinct(org.apache.calcite.test.PigRelBuilderStyleTest)  Time elapsed: 0.676 sec  <<< ERROR!
          java.lang.RuntimeException: org.apache.pig.impl.logicalLayer.FrontendException: ERROR 1066: Unable to open iterator for alias t
          	at org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:253)
          	at org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithGroupByCountDistinct(PigRelBuilderStyleTest.java:149)
          Caused by: org.apache.pig.impl.logicalLayer.FrontendException: Unable to open iterator for alias t
          	at org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:251)
          	at org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithGroupByCountDistinct(PigRelBuilderStyleTest.java:149)
          Caused by: java.io.IOException: Job terminated with anomalous status FAILED
          	at org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:251)
          	at org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithGroupByCountDistinct(PigRelBuilderStyleTest.java:149)
          

          Eli Levine, Can you see if you can reproduce/fix this intermittent failure? Not JDK-specific: I've seen it under JDK 1.7, 1.8 and 9.

          Show
          julianhyde Julian Hyde added a comment - 4. PigRelBuilderStyleTest.testImplWithGroupByCountDistinct Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.925 sec <<< FAILURE! - in org.apache.calcite.test.PigRelBuilderStyleTest testImplWithGroupByCountDistinct(org.apache.calcite.test.PigRelBuilderStyleTest) Time elapsed: 0.676 sec <<< ERROR! java.lang.RuntimeException: org.apache.pig.impl.logicalLayer.FrontendException: ERROR 1066: Unable to open iterator for alias t at org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:253) at org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithGroupByCountDistinct(PigRelBuilderStyleTest.java:149) Caused by: org.apache.pig.impl.logicalLayer.FrontendException: Unable to open iterator for alias t at org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:251) at org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithGroupByCountDistinct(PigRelBuilderStyleTest.java:149) Caused by: java.io.IOException: Job terminated with anomalous status FAILED at org.apache.calcite.test.PigRelBuilderStyleTest.assertScriptAndResults(PigRelBuilderStyleTest.java:251) at org.apache.calcite.test.PigRelBuilderStyleTest.testImplWithGroupByCountDistinct(PigRelBuilderStyleTest.java:149) Eli Levine , Can you see if you can reproduce/fix this intermittent failure? Not JDK-specific: I've seen it under JDK 1.7, 1.8 and 9.
          Hide
          elilevine Eli Levine added a comment -

          Julian Hyde, will take a look later today or tomorrow.

          Show
          elilevine Eli Levine added a comment - Julian Hyde , will take a look later today or tomorrow.
          Hide
          elilevine Eli Levine added a comment -

          Julian Hyde, this is a strange beast. I can't repro on either Mac or Linux. However, I remember that I was able to repro the inconsistent failures before, so not sure what's going on here. This test uses the PigTest class to execute Pig in local mode and perform data validation. PigTest creates data files in /tmp for result validation. I suspect these issues are related to local FS reads/writes but I can't confirm consistently, since I can't repro.

          What I remember from the last time I saw these failures is that one would only see the once. Everything worked fine on subsequent runs. What I will do is introduce a dummy run of PigTest before real tests are run in PigRelBuilderStyleTest. Let's see if it cuts down the noise. Will send a PR shortly.

          Show
          elilevine Eli Levine added a comment - Julian Hyde , this is a strange beast. I can't repro on either Mac or Linux. However, I remember that I was able to repro the inconsistent failures before, so not sure what's going on here. This test uses the PigTest class to execute Pig in local mode and perform data validation. PigTest creates data files in /tmp for result validation. I suspect these issues are related to local FS reads/writes but I can't confirm consistently, since I can't repro. What I remember from the last time I saw these failures is that one would only see the once. Everything worked fine on subsequent runs. What I will do is introduce a dummy run of PigTest before real tests are run in PigRelBuilderStyleTest. Let's see if it cuts down the noise. Will send a PR shortly.
          Hide
          elilevine Eli Levine added a comment -

          Did a bunch more digging and as far as I can tell this is due to the fact that PigTest's local Pig execution mode cannot read data files. Why it happens sporadically I could not determine, since I could never consistently repro. I have added some code to make PigTest's cluster aware of the files. Let's see if it improves things. Submitted a PR here: https://github.com/apache/calcite/pull/397

          Julian Hyde, FYI.

          Show
          elilevine Eli Levine added a comment - Did a bunch more digging and as far as I can tell this is due to the fact that PigTest's local Pig execution mode cannot read data files. Why it happens sporadically I could not determine, since I could never consistently repro. I have added some code to make PigTest's cluster aware of the files. Let's see if it improves things. Submitted a PR here: https://github.com/apache/calcite/pull/397 Julian Hyde , FYI.
          Hide
          julianhyde Julian Hyde added a comment -

          Issue #4 fixed (we believe) by http://git-wip-us.apache.org/repos/asf/calcite/commit/713c8f4f. Thanks for the PR, Eli Levine!

          Show
          julianhyde Julian Hyde added a comment - Issue #4 fixed (we believe) by http://git-wip-us.apache.org/repos/asf/calcite/commit/713c8f4f . Thanks for the PR, Eli Levine !
          Hide
          julianhyde Julian Hyde added a comment -

          Issue #4 is not fixed, so CALCITE-1751 disabled the test.

          Show
          julianhyde Julian Hyde added a comment - Issue #4 is not fixed, so CALCITE-1751 disabled the test.
          Hide
          elilevine Eli Levine added a comment -

          Thanks for disabling the tests, Josh Elser. Unfortunately these tests are coming from local Pig and not easy to debug, since they only happen sporadically locally. My hunch is that it has something to do with file permissions of files Pig creates locally but finding a viable fix has been elusive. What I will do is split up tests in the pig sub-module into unit and integration tests so only integration tests actually run local Pig.

          Show
          elilevine Eli Levine added a comment - Thanks for disabling the tests, Josh Elser . Unfortunately these tests are coming from local Pig and not easy to debug, since they only happen sporadically locally. My hunch is that it has something to do with file permissions of files Pig creates locally but finding a viable fix has been elusive. What I will do is split up tests in the pig sub-module into unit and integration tests so only integration tests actually run local Pig.
          Hide
          elserj Josh Elser added a comment -

          Thanks, Eli! I had taken a look at the output but it wasn't obvious to me as to why they were failing. I appreciate you picking these up to review!

          Show
          elserj Josh Elser added a comment - Thanks, Eli! I had taken a look at the output but it wasn't obvious to me as to why they were failing. I appreciate you picking these up to review!
          Hide
          julianhyde Julian Hyde added a comment -

          5. RemoteDriverTest.testBatchInsertWithDates (avatica)

          Failed tests: 
            RemoteDriverTest.testBatchInsertWithDates:1376->eachConnection:226->access$1100:91->executeBatchInsertWithDates:1441 Wrong day for row 0 expected:<1
          5> but was:<14>
            RemoteDriverTest.testBatchInsertWithDates:1376->eachConnection:226->access$1100:91->executeBatchInsertWithDates:1441 Wrong day for row 0 expected:<15> but was:<14>
          
          [INFO] Total time: 03:15 min
          [INFO] Finished at: 2017-04-15T11:13:24+01:00
          

          Note that "finished at" time, and its time zone. This test might have been run in the gap between one day and the next.

          cc Josh Elser

          Show
          julianhyde Julian Hyde added a comment - 5. RemoteDriverTest.testBatchInsertWithDates (avatica) Failed tests: RemoteDriverTest.testBatchInsertWithDates:1376->eachConnection:226->access$1100:91->executeBatchInsertWithDates:1441 Wrong day for row 0 expected:<1 5> but was:<14> RemoteDriverTest.testBatchInsertWithDates:1376->eachConnection:226->access$1100:91->executeBatchInsertWithDates:1441 Wrong day for row 0 expected:<15> but was:<14> [INFO] Total time: 03:15 min [INFO] Finished at: 2017-04-15T11:13:24+01:00 Note that "finished at" time, and its time zone. This test might have been run in the gap between one day and the next. cc Josh Elser
          Hide
          elserj Josh Elser added a comment -

          Note that "finished at" time, and its time zone. This test might have been run in the gap between one day and the next.

          Oh that's a funny test issue . I'll try to take a look at this one.

          Show
          elserj Josh Elser added a comment - Note that "finished at" time, and its time zone. This test might have been run in the gap between one day and the next. Oh that's a funny test issue . I'll try to take a look at this one.
          Hide
          julianhyde Julian Hyde added a comment -

          6. ConcurrentModificationException in testAmbiguousDynamicStar2 under JDK 7

          Caused by: java.util.ConcurrentModificationException
          	at org.apache.calcite.test.SqlValidatorTest.testAmbiguousDynamicStar2(SqlValidatorTest.java:9431)
          
          Show
          julianhyde Julian Hyde added a comment - 6. ConcurrentModificationException in testAmbiguousDynamicStar2 under JDK 7 Caused by: java.util.ConcurrentModificationException at org.apache.calcite.test.SqlValidatorTest.testAmbiguousDynamicStar2(SqlValidatorTest.java:9431)

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development